Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@417 PS4, Line 417: // Insert with partition. I think the priv req test covers this. This produces the same priv requests as L402 http://gerrit.cloudera.org:8080/#/c/10269/4/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@487 PS4, Line 487: authorize("insert into functional.zipcode_incomes(id) select '123'") Handle this with testPrivilegeRequests() -- To view, visit http://gerrit.cloudera.org:8080/10269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b Gerrit-Change-Number: 10269 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 22:58:57 +0000 Gerrit-HasComments: Yes
