Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10269 )
Change subject: IMPALA-6802 (part 2): Clean up authorization tests ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@563 PS3, Line 563: : // Use a non-existent database. : authorize("use nodb").error(accessError("nodb.*.*")); > I think the additional levels are unnecessary for default, but if they are Done http://gerrit.cloudera.org:8080/#/c/10269/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@573 PS3, Line 573: .ok(onServer(TPrivilegeLevel.INSERT)) : .ok(onDatabase("functional", TPrivilegeLevel.ALL)) : .ok(onDatabase("functional", TPrivilegeLevel.INSERT)) > Same as above. Done -- To view, visit http://gerrit.cloudera.org:8080/10269 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5bfd2f12bf0cc8ebe78464a523a7805366f67b Gerrit-Change-Number: 10269 Gerrit-PatchSet: 4 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Comment-Date: Fri, 04 May 2018 02:41:43 +0000 Gerrit-HasComments: Yes
