Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slot to use ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21257/1/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/21257/1/fe/src/main/java/org/apache/impala/planner/Planner.java@515 PS1, Line 515: CoreCount maxCores = root.maxCore(rootCores.first, CoreCount.sum(rootCores.second)); : Set<PlanFragmentId> dominantFragmentIds = : new HashSet<>(maxCores.getUniqueFragmentIds()); : int coresRequired = maxCores.total(); : : if (root.getSink() instanceof PlanRootSink && maxCores == rootCores.first) { : // exclude coordinator fragment from coresRequired. : coresRequired = Math.max(1, coresRequired - 1); : dominantFragmentIds.remove(root.getId()); : } : : for (PlanFragment fragment : postOrderFragments) { : if (dominantFragmentIds.contains(fragment.getId())) fragment.markDominant(); : } : : LOG.info("CoreCount=" + maxCores + ", coresRequired=" + coresRequired); : return coresRequired; Move this logic to caller method, computeProcessingCost(). -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 19:19:34 +0000 Gerrit-HasComments: Yes
