Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/21257/4/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21257/4/be/src/scheduling/scheduler.cc@1169 PS4, Line 1169: 'dominant_instan > 'dominant_instance_count' Done http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/planner/CoreCount.java File fe/src/main/java/org/apache/impala/planner/CoreCount.java: http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/planner/CoreCount.java@80 PS4, Line 80: a set of > This is not a copy. drop this. Done http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2396 PS4, Line 2396: getAvgSlotsUsePerBac > getAvgSlotsUsePerBackend Done -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 22:46:20 +0000 Gerrit-HasComments: Yes
