Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/21257/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21257/1//COMMIT_MSG@30 PS1, Line 30: > I'm considering changing this name. Maybe simply CPU_ASK is better. Renamed to PLANNER_CPU_ASK. http://gerrit.cloudera.org:8080/#/c/21257/4/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21257/4/be/src/scheduling/scheduler.cc@1169 PS4, Line 1169: be_max_instances 'dominant_instance_count' http://gerrit.cloudera.org:8080/#/c/21257/1/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/21257/1/common/thrift/Query.thrift@714 PS1, Line 714: // See comment in ImpalaService.thrift > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/21257/2/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/21257/2/common/thrift/Query.thrift@724 PS2, Line 724: 177: optional TSlotCountStrategy slot_count_strategy = > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/planner/CoreCount.java File fe/src/main/java/org/apache/impala/planner/CoreCount.java: http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/planner/CoreCount.java@80 PS4, Line 80: a copy of This is not a copy. drop this. http://gerrit.cloudera.org:8080/#/c/21257/1/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/21257/1/fe/src/main/java/org/apache/impala/planner/Planner.java@515 PS1, Line 515: : return root.maxCore(rootCores.first, CoreCount.sum(rootCores.second)); : } : : /** : * Reduce plan node cardinalities based on runtime filter information. : * Valid to call after runtime filter generation and before processing cost : * computation. : */ : public static void reduceCardinalityByRuntimeFilter( : List<PlanFragment> planRoots, PlannerContext planCtx) { : double reductionScale = planCtx.getRootAnalyzer() : .getQueryOptions() : .getRuntime_filter_cardinality_reduction_scale(); : if (reductionScale <= 0) return; : PlanFragment rootFragment = planRoots.get(0); : Stack<PlanNode> nodeS > Move this logic to caller method, computeProcessingCost(). Done http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21257/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2396 PS4, Line 2396: getSlotUsePerBackend getAvgSlotsUsePerBackend -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 08 Apr 2024 22:39:25 +0000 Gerrit-HasComments: Yes
