Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21284 )
Change subject: IMPALA-12990: Fix impala-shell handling of unset rows_deleted ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21284/2/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21284/2/shell/impala_client.py@980 PS2, Line 980: num_deleted_rows = 0 This seems right given how it's used in impala_shell.py. I also see a close_dml call that looks like it might be inadvertently wrong in test_hs2_fault_injection.py::TestHS2FaultInjection::test_close_dml, can you check whether it's calling this method and needs to be updated? I think we also need to update the same logic in ImpalaBeeswaxClient::close_dml and possibly StrictHS2Client::close_dml. Also the comment describing ImpalaClient::close_dml explicitly mentions that it returns None if the operation doesn't return rows_deleted, so it would need to be updated too. http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py@932 PS2, Line 932: def _test_dml_reporting(self, vector, create_sql, db, is_kudu): Do these get run with both HS2 and Beeswax? -- To view, visit http://gerrit.cloudera.org:8080/21284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5812b8006b9cacf34a7a0dbbc89a486d8b454438 Gerrit-Change-Number: 21284 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 10 Apr 2024 17:53:18 +0000 Gerrit-HasComments: Yes
