Peter Rozsa has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21284 )

Change subject: IMPALA-12990: Fix impala-shell handling of unset rows_deleted
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py@925
PS2, Line 925:   def test_iceberg_dml_reporting(self, vector, unique_database):
> Changed the function to make the Kudu / Iceberg differences more explicit a
Thank you, it's clearer now.


http://gerrit.cloudera.org:8080/#/c/21284/4/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/21284/4/tests/shell/test_shell_commandline.py@961
PS4, Line 961: Kude
typo: Kudu



--
To view, visit http://gerrit.cloudera.org:8080/21284
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5812b8006b9cacf34a7a0dbbc89a486d8b454438
Gerrit-Change-Number: 21284
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Thu, 11 Apr 2024 12:25:25 +0000
Gerrit-HasComments: Yes

Reply via email to