Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21284 )
Change subject: IMPALA-12990: Fix impala-shell handling of unset rows_deleted ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py@925 PS2, Line 925: def test_iceberg_dml_reporting(self, vector, unique_database): Reusing the Kudu DML sequence makes this new test compact but a bit complex. Maybe creating a separate test sequence for Iceberg should simplify it, at the cost of adding duplicate rows, but these duplicates, in my opinion, can be reasonable as they have different semantics. -- To view, visit http://gerrit.cloudera.org:8080/21284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5812b8006b9cacf34a7a0dbbc89a486d8b454438 Gerrit-Change-Number: 21284 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2024 09:31:44 +0000 Gerrit-HasComments: Yes
