Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21284 )
Change subject: IMPALA-12990: Fix impala-shell handling of unset rows_deleted ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21284/2/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/21284/2/shell/impala_client.py@980 PS2, Line 980: self._check_hs2_rpc_status(resp.status) > About TestHS2FaultInjection::test_close_dml: Ah, I assumed the comment referred to num_deleted_rows but looks like it was never updated to include that. It'd be nice to have StrictHS2Client::close_dml match the return layout even if not used. But not required. http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/21284/2/tests/shell/test_shell_commandline.py@932 PS2, Line 932: def _test_dml_reporting(self, vector, create_sql, db, is_kudu): > Yes ... but as I learned the Python3 + beeswax combination is only run in e Ack -- To view, visit http://gerrit.cloudera.org:8080/21284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5812b8006b9cacf34a7a0dbbc89a486d8b454438 Gerrit-Change-Number: 21284 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 11 Apr 2024 17:12:28 +0000 Gerrit-HasComments: Yes
