Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 11: (4 comments) Thank you for the review so far, I will push a new patch set today. http://gerrit.cloudera.org:8080/#/c/21257/11/testdata/workloads/functional-query/queries/QueryTest/processing_cost_admission_slots.test File testdata/workloads/functional-query/queries/QueryTest/processing_cost_admission_slots.test: http://gerrit.cloudera.org:8080/#/c/21257/11/testdata/workloads/functional-query/queries/QueryTest/processing_cost_admission_slots.test@2 PS11, Line 2: ---- QUERY > It would be very nice to add an explain for the same query with the same qu The EXPLAIN plan should be equal to the one in workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q01.test. I will mention it as a comment. The RUNTIME_PROFILE section in this test assert FrontendProfile section that does not belong to the EXPLAIN part. Therefore, this is written as EE test and not FE test. http://gerrit.cloudera.org:8080/#/c/21257/11/testdata/workloads/functional-query/queries/QueryTest/processing_cost_admission_slots.test@31 PS11, Line 31: ---- RESULTS > Are the results actually important here? Will delete this RESULTS section. http://gerrit.cloudera.org:8080/#/c/21257/11/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/21257/11/tests/custom_cluster/test_executor_groups.py@1245 PS11, Line 1245: # CoreCount={total=16 trace=F15:3+F01:1+F14:3+F03:1+F13:3+F05:1+F12:3+F07:1}, > This is very useful to help in understanding the patch, but it would be bet I will mention the planner test for TPC-DS Q1 here. http://gerrit.cloudera.org:8080/#/c/21257/11/tests/query_test/test_processing_cost.py File tests/query_test/test_processing_cost.py: http://gerrit.cloudera.org:8080/#/c/21257/11/tests/query_test/test_processing_cost.py@42 PS11, Line 42: add_mandatory_exec_option(cls, 'slot_count_strategy', 'planner_cpu_ask') > IMO moving these to SET statements in the .test file would be clearer. It w Will do. -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2024 15:40:44 +0000 Gerrit-HasComments: Yes
