Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG@19 PS11, Line 19: rather : than sum of it (48) > Can this get higher than the amount of slots per executor? Based on IMPALA- It can be, if individual executor is configured with mismatch --admission_control_slots value than what is expressed in llama-site.xml of coordinator (field name like "impala.admission-control.max-query-cpu-core-per-node-limit.root.large", for root.large executor group). This patch assume correct configuration between llama-site.xml of coordinator and --admission_control_slots value of each backend executors. http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG@28 PS11, Line 28: which will be a closer resemblance of maximum : parallel execution of fragment instances. > Does PLANNER_CPU_ASK always calculate a greater or equal number of slots th It should be most of the time, except few corner cases such as dedicated coordinator setup. In that setup, there might be no dominant fragment assigned to coordinator at all. This is handled by L1027 at scheduler.cc, patch set 11. Now that I think again, I might miss other corner cases where dominant_instance_count < be_max_instances, I just have not found such example. I think be_max_instances should win in that case. Will fix it in next patch set. -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 11 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 15 Apr 2024 16:09:38 +0000 Gerrit-HasComments: Yes
