Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21257 )
Change subject: IMPALA-12980: Translate CpuAsk into admission control slots ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21257/11//COMMIT_MSG@19 PS11, Line 19: rather : than sum of it (48) > It can be, if individual executor is configured with mismatch --admission_c So if the configuration is correct, then cpuask will be always <= the number of cores? I think that what needs a bit of explanation is "12 cores oversubscribed by 4x" - this suggests to me that this is inherently wrong, but if the number of cores is less than the number of parallel fragments (possible in queries with lot of small build fragments), then oversubscribing is normal, right? http://gerrit.cloudera.org:8080/#/c/21257/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21257/13//COMMIT_MSG@37 PS13, Line 37: more I think that it should be "more or equal" (same applies to comment in Query.thrift) http://gerrit.cloudera.org:8080/#/c/21257/13/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21257/13/be/src/scheduling/scheduler.cc@1209 PS13, Line 1209: in nit: "is" http://gerrit.cloudera.org:8080/#/c/21257/13/be/src/scheduling/scheduler.cc@1209 PS13, Line 1209: is nit: "is" not needed -- To view, visit http://gerrit.cloudera.org:8080/21257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I338ca96555bfe8d07afce0320b3688a0861663f2 Gerrit-Change-Number: 21257 Gerrit-PatchSet: 13 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 16 Apr 2024 06:52:12 +0000 Gerrit-HasComments: Yes
