Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@18 PS13, Line 18: addresses makes http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@18 PS13, Line 18: two I've almost forgotten the third: the list of characters to be escaped was extended to match the current list in Hive. http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@19 PS13, Line 19: there was a "set" I didn't mean it as a literal text to be included. Instead, it could be: "Before the change, the set of characters that need to be escaped was stored as a string. The current patch uses an unordered_set instead." http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@25 PS13, Line 25: Nit: "... byte and whose inclusion ...". -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 13 Gerrit-Owner: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <pranav.lo...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Tue, 30 Apr 2024 11:31:32 +0000 Gerrit-HasComments: Yes
