[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 18: (2 comments) > Uploaded patch set 18. http://gerrit.cloudera.org:8080/#/c/21131/15/be/src/util/coding-util.cc File be/src/util/coding-util.cc: http://gerrit.cloudera.org:8080/#/c/21131/15/be/src/util/coding-util.cc@66 PS15, Line 66: !isalnum(static_cast<unsigned char>(ch)) && !ShouldNotEscape(ch))) { > I played with it a bit and it doesn't work with for example '\t' and '\n' ( Done. Note: I tested those cases manually but to include those tests we'll have to bring a change in the test framework, which in its current state prevents us to write such tests. For example, '\t ' is considered a separator in our current test framework, so to incorporate such tests we might have to change the test framework which might lead to other errors, That's why I haven't included such cases in the current tests. http://gerrit.cloudera.org:8080/#/c/21131/15/be/src/util/coding-util.cc@66 PS15, Line 66: c > I think it would be good if we first cast it to unsigned char because of wh Done -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 18 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Mon, 06 May 2024 04:37:55 +0000 Gerrit-HasComments: Yes
