[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21131 )
Change subject: IMPALA-11499: Refactor UrlEncode function to handle special characters ...................................................................... Patch Set 14: (4 comments) > Uploaded patch set 14: Commit message was updated. http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@18 PS13, Line 18: thr > I've almost forgotten the third: the list of characters to be escaped was e Done http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@18 PS13, Line 18: addresses > makes I think that's inferred. http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@19 PS13, Line 19: the set of charac > I didn't mean it as a literal text to be included. Instead, it could be: Done http://gerrit.cloudera.org:8080/#/c/21131/13//COMMIT_MSG@25 PS13, Line 25: n > Nit: "... byte and whose inclusion ...". Done -- To view, visit http://gerrit.cloudera.org:8080/21131 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88c4aba5d811dfcec809583d0c16fcbc0ca730fb Gerrit-Change-Number: 21131 Gerrit-PatchSet: 14 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2024 11:44:25 +0000 Gerrit-HasComments: Yes
