Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 )
Change subject: IMPALA-13038: Support profile tab for imported query profiles ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21400/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/21400/3/be/src/service/impala-http-handler.cc@307 PS3, Line 307: Value query_id_val(PrintId(unique_id).c_str(), document->GetAllocator()); Move these after parse_status error check. http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl File www/query_profile.tmpl: http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl@62 PS3, Line 62: result += `${indent} Offset: ${eventSeq.offset}\n`; Check performance of these repeated appends. It may be better to accumulate the sections into separate strings then append at the return. http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl@113 PS3, Line 113: query.id = query.id.substring(10, query.id.indexOf("&")); Is there a tag that can be checked here? Please add a comment of where this URL/string comes from and what the format is. -- To view, visit http://gerrit.cloudera.org:8080/21400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddcf2e285abbf42f97bde19014be076ccd6374bc Gerrit-Change-Number: 21400 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 08 May 2024 14:09:26 +0000 Gerrit-HasComments: Yes
