Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 )
Change subject: IMPALA-13038: Support profile tab for imported query profiles ...................................................................... Patch Set 5: (2 comments) > Tried the patch set 4. Timeline tab shows nothing for an imported > json profile. Other three tabs work fine. Could you please tell me whats the error in the browser console? http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl File www/query_profile.tmpl: http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl@62 PS3, Line 62: profile.event_sequences.forEach(eventSeq => { > Is this approach actually faster? Concatenation is only efficient if the st Done. When there are more than one variables to concatenate, one pass through with es6 template strings is more efficient than +=. Also, this uses less space as only a single string is allocated and previous is deallocated. Though if we divide up as sections, even though it may use more space. This will require less copying, and maybe faster for this reason. This time I have used good parts of both. http://gerrit.cloudera.org:8080/#/c/21400/4/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/21400/4/www/scripts/util.js@105 PS4, Line 105: let query_id = window.location.search.split("query_id=")[1]; > Should parse out using the query_id tag. These attributes can appear in any Done. I have used tags this time. Though, this function is only used for imported query profiles, the links are in a set format according to query_details_tab. -- To view, visit http://gerrit.cloudera.org:8080/21400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddcf2e285abbf42f97bde19014be076ccd6374bc Gerrit-Change-Number: 21400 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 09 May 2024 10:06:01 +0000 Gerrit-HasComments: Yes
