Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21400 )
Change subject: IMPALA-13038: Support profile tab for imported query profiles ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl File www/query_profile.tmpl: http://gerrit.cloudera.org:8080/#/c/21400/3/www/query_profile.tmpl@62 PS3, Line 62: result = `${result}${indent} Offset: ${eventSeq.offset}\n`; > Check performance of these repeated appends. It may be better to accumulate Is this approach actually faster? Concatenation is only efficient if the string doesn't reserve space. Please check javascript docs and measure performance. http://gerrit.cloudera.org:8080/#/c/21400/4/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/21400/4/www/scripts/util.js@105 PS4, Line 105: return window.location.search.substring(10,window.location.search.indexOf("&")); Should parse out using the query_id tag. These attributes can appear in any order in URLs. -- To view, visit http://gerrit.cloudera.org:8080/21400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddcf2e285abbf42f97bde19014be076ccd6374bc Gerrit-Change-Number: 21400 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 08 May 2024 20:02:08 +0000 Gerrit-HasComments: Yes
