Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 )
Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys ...................................................................... Patch Set 21: (3 comments) http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java: http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@573 PS21, Line 573: "", statestoreWebserverArgs, 0 If read jwks from local file, then don't need these three parameters, and don't need variable statestoreWebserverArgs http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@585 PS21, Line 585: impala Should be 'jwt-cpp.example.localhost' http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@598 PS21, Line 598: // Authenticate fails due JWT verification failure since the RS256 public key cannot : // be found in the JWKS. : transport.setCustomHeaders(headers); : try { : openResp = client.OpenSession(openReq); : } catch (Exception e) { : verifyJwtAuthMetrics(3, 1); : assertEquals(e.getMessage(), "HTTP Response code: 401"); : } This negative test is dependent on the JWKS change in running time. It should be removed since you read JWKS from local file now, and jwks will not be changed in running time. -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 21 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2024 00:44:00 +0000 Gerrit-HasComments: Yes
