gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/21382 )
Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys ...................................................................... Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util-test.cc File be/src/util/jwt-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21382/20/be/src/util/jwt-util-test.cc@322 PS20, Line 322: kid_x5c > I think the value of this constant still needs to be "internal-gateway-jwt. In the latest version, the jwks is updated to also have kid: "kid_x5c". If they do not match then the verify will fail. http://gerrit.cloudera.org:8080/#/c/21382/22/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java: http://gerrit.cloudera.org:8080/#/c/21382/22/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@567 PS22, Line 567: String jwksFilename = > nit: it's unused Removed. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/21382 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74 Gerrit-Change-Number: 21382 Gerrit-PatchSet: 23 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2024 17:10:23 +0000 Gerrit-HasComments: Yes
