gaurav singh has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21382 )

Change subject: IMPALA-12559: Support x5c Parameter for RSA JSON Web Keys
......................................................................


Patch Set 20:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java
File fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:

http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@573
PS21, Line 573: ate_frequency_s=1 --jwt_allow_w
> If read jwks from local file, then don't need these three parameters, and d
Done


http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@585
PS21, Line 585: Client
> Should be 'jwt-cpp.example.localhost'
Done


http://gerrit.cloudera.org:8080/#/c/21382/21/fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java@598
PS21, Line 598:  verifyJwtAuthMetrics(3, 0);
              :
              :     // Update JWKS in the root directory of Web server.
              :     createTempJWKSInWebServerRootDir("jwks_x5c_rs256.json");
              :     // Sleep long enough for coordinator to update JWKS from 
Web server.
              :     Thread.sleep(3000);
              :     // Authenticate fails due JWT verification failure since 
the RS256 public key cannot
              :     // be found in the JWKS.
              :     t
> This negative test is dependent on the JWKS change in running time. It shou
Done



--
To view, visit http://gerrit.cloudera.org:8080/21382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I70be6f9f54190544aa005b2644e2ed8db6f6bb74
Gerrit-Change-Number: 21382
Gerrit-PatchSet: 20
Gerrit-Owner: gaurav singh <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Tue, 14 May 2024 16:05:53 +0000
Gerrit-HasComments: Yes

Reply via email to