Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 )
Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21412/2/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/21412/2/be/src/service/client-request-state.h@498 PS2, Line 498: void UpdateGetInFlightProfileTime(int64_t elapsed_time_ns); nit: we usually include a comment describing the function. Might be nice to reference the visible metric name it updates. Also might make sense as inline functions since they're so simple. http://gerrit.cloudera.org:8080/#/c/21412/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/21412/2/tests/query_test/test_observability.py@974 PS2, Line 974: query_id = query_id_search.group(1) Doesn't handle.query_id have the query ID? Not sure why you're parsing the profile. -- To view, visit http://gerrit.cloudera.org:8080/21412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I538ebe914f70f460bc8412770a8f7a1cc8b505dc Gerrit-Change-Number: 21412 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 14 May 2024 21:16:08 +0000 Gerrit-HasComments: Yes
