Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 )
Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21412/2/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/21412/2/be/src/service/client-request-state.h@498 PS2, Line 498: > Done. Implicitly inline them by defining them here (inside the declaration Done http://gerrit.cloudera.org:8080/#/c/21412/2/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/21412/2/tests/query_test/test_observability.py@974 PS2, Line 974: impalad = cluster.get_first_impalad() > Didn't dig deeper into this. We can use handle.get_handle().id here. Done -- To view, visit http://gerrit.cloudera.org:8080/21412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I538ebe914f70f460bc8412770a8f7a1cc8b505dc Gerrit-Change-Number: 21412 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 17 May 2024 17:18:55 +0000 Gerrit-HasComments: Yes
