Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 )
Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/client-request-state.h@506 PS3, Line 506: void AddClientFetchLockWaitTime(int64_t lock_wait_time_ns) { > another review uses "AddFetchLockWaitTime" for similar purpose. https://ger Oops, just realized that patch. http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-beeswax-server.cc@352 PS3, Line 352: VLOG(1) << "Error in get_log, could not get query hand > Is this supposed to be a long term log? It could contain more information, Done http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/21412/3/be/src/service/impala-hs2-server.cc@1099 PS3, Line 1099: VLOG(1) << "Error in GetLog, could not get query handle: " << status.GetDetail(); > Same as in impala-beeswax-server.cc Done -- To view, visit http://gerrit.cloudera.org:8080/21412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I538ebe914f70f460bc8412770a8f7a1cc8b505dc Gerrit-Change-Number: 21412 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2024 02:42:57 +0000 Gerrit-HasComments: Yes
