Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 )
Change subject: IMPALA-12562: Cast double and float to string with exact presicion ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21441/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21441/2//COMMIT_MSG@12 PS2, Line 12: le a > Can you provide some benchmarks? I expect it to be an improvement, but it w I added some benchmarks, I guess this could bring a slight performance degradation since it does more work to print more accurate results. According to comments in gutil/strings/numbers.cc, these implementations are about as fast as other strategies and do not need to introduce a new library. http://gerrit.cloudera.org:8080/#/c/21441/2/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21441/2/be/src/exprs/cast-functions-ir.cc@344 PS2, Line 344: if (val.is_null) return StringVal::null(); \ > At this point no allocation happened yet so this check is not useful. Done http://gerrit.cloudera.org:8080/#/c/21441/2/be/src/exprs/cast-functions-ir.cc@355 PS2, Line 355: sary(ctx-> > I would prefer using DoubleToBuffer / FloatToBuffer as it avoids the extra Done -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd79c55dd57dc0fa13e4ec11c2284ef2800e8b1a Gerrit-Change-Number: 21441 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 22 May 2024 09:56:21 +0000 Gerrit-HasComments: Yes
