Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 )
Change subject: IMPALA-12562: Cast double and float to string with exact presicion ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21441/3/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21441/3/be/src/exprs/cast-functions-ir.cc@352 PS3, Line 352: strlen > It seems that the returned pointer doesn't point to the terminating null by You are right, sorry, I was confused by the way FastInt32ToBufferLeft and friends work and thought that FloatToBuffer/DoubleToBuffer doesn't point to the beginning of the buffer. -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd79c55dd57dc0fa13e4ec11c2284ef2800e8b1a Gerrit-Change-Number: 21441 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2024 12:53:28 +0000 Gerrit-HasComments: Yes
