Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 )
Change subject: IMPALA-12562: Cast double and float to string with exact presicion ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21441/3/be/src/exprs/cast-functions-ir.cc File be/src/exprs/cast-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/21441/3/be/src/exprs/cast-functions-ir.cc@352 PS3, Line 352: strlen > strlen could be avoid by saving the original pointer and comparing the diff It seems that the returned pointer doesn't point to the terminating null byte and it can't be used to compare with the original pointer. I also found this strlen redundant, since snprintf returns the length of the buffer. Maybe we have to use strlen if we don't want to change implementations in gutil/strings. -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd79c55dd57dc0fa13e4ec11c2284ef2800e8b1a Gerrit-Change-Number: 21441 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 23 May 2024 08:33:27 +0000 Gerrit-HasComments: Yes
