Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21463 )
Change subject: IMPALA-13106: Support larger imported query profile sizes through compression ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21463/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21463/2//COMMIT_MSG@14 PS2, Line 14: pako What version is pako.min.js in this patch? Please mention it explicitly in commit message. http://gerrit.cloudera.org:8080/#/c/21463/2/www/query_stmt.tmpl File www/query_stmt.tmpl: http://gerrit.cloudera.org:8080/#/c/21463/2/www/query_stmt.tmpl@68 PS2, Line 68: JSON.parse(pako.inflate(e.target.result.profile, {to : "string"})) Can you contain this into its own function? Maybe also add console.log() about the inflate/deflate size and speed. Please also write test to deflate-inflate and verify that the JSON match. -- To view, visit http://gerrit.cloudera.org:8080/21463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4f31beb9cac89051460bf764b6d50c3933bd03 Gerrit-Change-Number: 21463 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 28 May 2024 20:45:55 +0000 Gerrit-HasComments: Yes
