Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21463 )
Change subject: IMPALA-13106: Support larger imported query profile sizes through compression ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21463/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21463/2//COMMIT_MSG@14 PS2, Line 14: pako > What version is pako.min.js in this patch? Please mention it explicitly in Done http://gerrit.cloudera.org:8080/#/c/21463/2//COMMIT_MSG@16 PS2, Line 16: > Should we make 'compression' as option to be enabled? For small profiles, compression is very fast. For big files, there is no other way to insert them into indexedDB without compression due to the size limit. So, I believe users should not be able to toogle this. http://gerrit.cloudera.org:8080/#/c/21463/2/www/query_stmt.tmpl File www/query_stmt.tmpl: http://gerrit.cloudera.org:8080/#/c/21463/2/www/query_stmt.tmpl@68 PS2, Line 68: db.transaction("profiles", "readonly").objectStore("profiles"); > Can you contain this into its own function? Maybe also add console.log() ab Done -- To view, visit http://gerrit.cloudera.org:8080/21463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4f31beb9cac89051460bf764b6d50c3933bd03 Gerrit-Change-Number: 21463 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 31 May 2024 17:32:30 +0000 Gerrit-HasComments: Yes
