Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21463 )
Change subject: IMPALA-13106: Support larger imported query profile sizes through compression ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21463/4/www/scripts/tests/queries/profileParseWorker.test.js File www/scripts/tests/queries/profileParseWorker.test.js: http://gerrit.cloudera.org:8080/#/c/21463/4/www/scripts/tests/queries/profileParseWorker.test.js@26 PS4, Line 26: ../../.. > nit: Maybe use $IMPALA_HOME env var instead? In many .tmpl files relative paths had been used previously. So, I have used relative paths in all scripts and tests. I believe it won't be a problem, unless the "www" folder was relocated, it would require a lot of changes to paths, not just here. Is it advisable to post a patch, to fix all paths everywhere in www? http://gerrit.cloudera.org:8080/#/c/21463/4/www/scripts/tests/queries/profileParseWorker.test.js@28 PS4, Line 28: import("../../../pako.min.js").then((pako) => { : pako = pako.default; : expect(pako.inflate(pako.deflate(exampleJSONProfileText, {level : 3}), {to : "string"})) : .toBe(exampleJSONProfileText); : }); > Instead of just testing the compress-decompress, what if this test instanti We cannot use/instantiate web workers in JEST framework or most other testing frameworks. Hence, I only tested the library method's we are using for compression. -- To view, visit http://gerrit.cloudera.org:8080/21463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4f31beb9cac89051460bf764b6d50c3933bd03 Gerrit-Change-Number: 21463 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 11 Jun 2024 09:59:01 +0000 Gerrit-HasComments: Yes
