Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 )
Change subject: IMPALA-12705: Add /catalog_ha_info page on Statestore to show catalog HA information ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py@64 PS16, Line 64: VARZ_URL = "http://localhost:{0}/varz"; : CATALOG_HA_INFO_URL = "http://localhost:{0}/catalog_ha_info"; : JSON_METRICS_URL = "http://localhost:{0}/jsonmetrics"; move these new variables to class TestWebPageAndCloseSession since they are used by new test cases. http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py@76 PS16, Line 76: SS_TEST_PORT = ["25010"] move this new variables to class TestWebPageAndCloseSession since it is used by new test cases. tried to run new test case, got following error: tests/webserver/test_web_pages.py:1177: in test_enable_catalog_ha self.__test_catalog_ha_info() tests/webserver/test_web_pages.py:1180: in __test_catalog_ha_info for port in self.SS_TEST_PORT: E AttributeError: 'TestWebPageAndCloseSession' object has no attribute 'SS_TEST_PORT' http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py@1142 PS16, Line 1142: TestWebPageAndCloseSession(CustomClusterTestSuite) Don't make this change for an existing class since it will affect existing test cases. Instead, add a new test class for your new test functions. There is no test class derived from CustomClusterTestSuite in existing test python scripts under tests/webserver. It's better to add the new class to tests/custom_cluster/test_catalogd_ha.py -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3 Gerrit-Change-Number: 21418 Gerrit-PatchSet: 16 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2024 00:51:42 +0000 Gerrit-HasComments: Yes
