ttttttz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21418 )

Change subject: IMPALA-12705: Add /catalog_ha_info page on Statestore to show 
catalog HA information
......................................................................


Patch Set 17:

(3 comments)

Hi, Wenzhe! I moved the test to test_catalogd_ha.py and passed.

http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py@64
PS16, Line 64: # log4j changes do not apply to the statestore since it doesn't
             :   # have an embedded JVM. So we make two sets of ports to test 
the
             :   # log level endpoints, one without the statestore por
> move these new variables to class TestWebPageAndCloseSession since they are
Ack


http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py@76
PS16, Line 76:
> move this new variables to class TestWebPageAndCloseSession since it is use
Ack


http://gerrit.cloudera.org:8080/#/c/21418/16/tests/webserver/test_web_pages.py@1142
PS16, Line 1142: Check the runtime profile and the INFO logs for th
> Don't make this change for an existing class since it will affect existing
Ack



--
To view, visit http://gerrit.cloudera.org:8080/21418
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If85f6a827ae8180d13caac588b92af0511ac35e3
Gerrit-Change-Number: 21418
Gerrit-PatchSet: 17
Gerrit-Owner: ttttttz <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Zihao Ye <[email protected]>
Gerrit-Reviewer: ttttttz <[email protected]>
Gerrit-Comment-Date: Wed, 05 Jun 2024 03:03:22 +0000
Gerrit-HasComments: Yes

Reply via email to