Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21476 )
Change subject: IMPALA-13130: Prioritize EndDataStream messages ...................................................................... Patch Set 4: (5 comments) > Patch Set 2: > > (4 comments) > > Can you craft a BE test for this patch under data-stream-test.cc? > Maybe a combination of DataStreamTestShortServiceQueue and > DataStreamTest_Cancel to show that EndDataStream RPC can move ahead in the > queue? I'm still working on adding a test; having trouble coming up with something deterministic that does more than log the warning. http://gerrit.cloudera.org:8080/#/c/21476/2/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/21476/2/be/src/rpc/impala-service-pool.cc@187 PS2, Line 187: // may cause the MemTracker's limit to be exc > Looks like we intentionally ignore HARD MemLimit here. Please clarify in co Done http://gerrit.cloudera.org:8080/#/c/21476/3/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/21476/3/be/src/rpc/impala-service-pool.cc@183 PS3, Line 183: sferSize(); > Make this a constant string and add the following DCHECK in DataStreamServi Done. I'd really prefer this to be an abstraction, but since we're working through kudu::rpc::GeneratedServiceIf I'd have to change Kudu code to add a "PrioritizeCall" method. http://gerrit.cloudera.org:8080/#/c/21476/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21476/2/be/src/runtime/krpc-data-stream-sender.cc@65 PS2, Line 65: Defau > Maybe something shorter like 1 hour is better? Done http://gerrit.cloudera.org:8080/#/c/21476/2/be/src/runtime/krpc-data-stream-sender.cc@65 PS2, Line 65: DataStream > nit: "other DataStreamService RPCs" Done http://gerrit.cloudera.org:8080/#/c/21476/2/be/src/runtime/krpc-data-stream-sender.cc@685 PS2, Line 685: rpc_controller_.set_timeout( : MonoDelta::FromMilliseconds(FLAGS_data_stream_sender_eos_timeout_ms)); > nit: Are we leaving other RPC of DataStreamService with no timeout set? Leaving them unset. I'm not sure what value explicitly setting them to the default would add. -- To view, visit http://gerrit.cloudera.org:8080/21476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2829e1ab5bcde36107e10bff5fe629c5ee60f3e8 Gerrit-Change-Number: 21476 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2024 17:49:04 +0000 Gerrit-HasComments: Yes
