Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21476 )
Change subject: IMPALA-13130: Prioritize EndDataStream messages ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/21476/5/be/src/runtime/data-stream-test.cc File be/src/runtime/data-stream-test.cc: http://gerrit.cloudera.org:8080/#/c/21476/5/be/src/runtime/data-stream-test.cc@867 PS5, Line 867: TEST_F(DataStreamTestSlowServiceQueue, TestPrioritizeEos) { Add comment describing what this test does. http://gerrit.cloudera.org:8080/#/c/21476/5/be/src/runtime/data-stream-test.cc@899 PS5, Line 899: EXPECT_LT(timer.ElapsedTime(), 6 * kudu::MonoTime::kNanosecondsPerSecond); Should we add the following after JoinReceivers()? EXPECT_GE(timer.ElapsedTime(), 6 * kudu::MonoTime::kNanosecondsPerSecond); http://gerrit.cloudera.org:8080/#/c/21476/5/be/src/runtime/data-stream-test.cc@914 PS5, Line 914: TEST_F(DataStreamTestShortServiceQueue, TestFullQueue) { Add comment describing what this test does. http://gerrit.cloudera.org:8080/#/c/21476/5/be/src/runtime/data-stream-test.cc@944 PS5, Line 944: EXPECT_LT(timer.ElapsedTime(), 3 * kudu::MonoTime::kNanosecondsPerSecond); Should we add the following after JoinReceivers()? EXPECT_GE(timer.ElapsedTime(), 3 * kudu::MonoTime::kNanosecondsPerSecond); http://gerrit.cloudera.org:8080/#/c/21476/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21476/4/be/src/runtime/krpc-data-stream-sender.cc@65 PS4, Line 65: Set to -1 > Is there some reason you think it allows setting to 0? 0 should be considered as invalid timeout. This is in inbound_call.cc // Compute and cache the call deadline. if (header_.has_timeout_millis() && header_.timeout_millis() != 0) { deadline_ = timing_.time_received + MonoDelta::FromMilliseconds(header_.timeout_millis()); } So flag description should say "Set to 0 or negative value to disable the timeout." -- To view, visit http://gerrit.cloudera.org:8080/21476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2829e1ab5bcde36107e10bff5fe629c5ee60f3e8 Gerrit-Change-Number: 21476 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2024 23:18:57 +0000 Gerrit-HasComments: Yes
