Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21476 )
Change subject: IMPALA-13130: Prioritize EndDataStream messages ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21476/4/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21476/4/be/src/runtime/krpc-data-stream-sender.cc@65 PS4, Line 65: Set to -1 > nit: 0 is also ignored in line 682 Yeah, I was omitting that. Maybe I should enforce a minimum timeout? I think setting it to 0 might cause problems. Or I can just make the check below match. -- To view, visit http://gerrit.cloudera.org:8080/21476 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2829e1ab5bcde36107e10bff5fe629c5ee60f3e8 Gerrit-Change-Number: 21476 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 05 Jun 2024 19:44:51 +0000 Gerrit-HasComments: Yes
