Jason Fehr has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21544


Change subject: IMPALA-13128: disk-file-test Hangs on ARM + UBSAN Test Jobs
......................................................................

IMPALA-13128: disk-file-test Hangs on ARM + UBSAN Test Jobs

The Jenkins jobs that run the UBSAN tests on ARM were occaisonally
hanging on the disk-file-test. This commit fixes these hangs by
upgrading Google Test and implementing the Death Test handling
functionality which safely runs tests that expect the process to die.
See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests
for details on known problems with running death tests and threads at
the same time causing tests to hang.

Testing was accomplished by running the disk-file-test repeatedly in a
loop on a RHEL 8.9 ARM machine. Before this fix was implemented, this
test would run up to 70 times before it hung. After the fix was
implemented, the test ran 2,490 times and was still running when it was
stopped.

Change-Id: Ie01f7781f24644a66e9ec52652450116f5cb4297
---
M CMakeLists.txt
M be/src/codegen/llvm-codegen-test.cc
M be/src/exec/json/json-parser-test.cc
M be/src/exprs/expr-test.cc
M be/src/rpc/rpc-mgr-kerberized-test.cc
M be/src/rpc/rpc-mgr-test.cc
M be/src/rpc/thrift-server-test.cc
M be/src/runtime/io/CMakeLists.txt
M be/src/runtime/io/data-cache-test.cc
M be/src/runtime/io/disk-file-test.cc
M be/src/util/cache/cache-bench.cc
M be/src/util/cache/cache-test.cc
M be/src/util/cache/rl-cache-test.cc
M be/src/util/runtime-profile-test.cc
M bin/bootstrap_toolchain.py
M bin/impala-config.sh
16 files changed, 33 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/44/21544/2
--
To view, visit http://gerrit.cloudera.org:8080/21544
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie01f7781f24644a66e9ec52652450116f5cb4297
Gerrit-Change-Number: 21544
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>

Reply via email to