Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21544 )
Change subject: IMPALA-13128: disk-file-test Hangs on ARM + UBSAN Test Jobs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21544/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/21544/2/be/src/exprs/expr-test.cc@11430 PS2, Line 11430: INSTANTIATE_TEST_SUITE_P(Instantiations, ExprTest, ::testing::Values( > This was renamed in newer googletest versions? They deprecated the other syntax and clang builds fail if we don't switch. http://gerrit.cloudera.org:8080/#/c/21544/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21544/2/bin/impala-config.sh@88 PS2, Line 88: export IMPALA_TOOLCHAIN_BUILD_ID_AARCH64=43-49c2fc592d : export IMPALA_TOOLCHAIN_BUILD_ID_X86_64=435-49c2fc592d We'll need a different toolchain build, because this contains other things that aren't checked in and I didn't build all the different Linux distros for x86. -- To view, visit http://gerrit.cloudera.org:8080/21544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01f7781f24644a66e9ec52652450116f5cb4297 Gerrit-Change-Number: 21544 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2024 22:37:36 +0000 Gerrit-HasComments: Yes
