Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21544 )
Change subject: IMPALA-13128: disk-file-test Hangs on ARM + UBSAN Test Jobs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21544/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21544/2//COMMIT_MSG@13 PS2, Line 13: See https://github.com/google/googletest/blob/main/docs/advanced.md#death-tests > What does this do to backend test execution time? Good question. Adds about 15 seconds to the overall build time. I updated the commit message with test duration information. http://gerrit.cloudera.org:8080/#/c/21544/2/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/21544/2/bin/impala-config.sh@88 PS2, Line 88: export IMPALA_TOOLCHAIN_BUILD_ID_AARCH64=43-49c2fc592d : export IMPALA_TOOLCHAIN_BUILD_ID_X86_64=435-49c2fc592d > We'll need a different toolchain build, because this contains other things Ack -- To view, visit http://gerrit.cloudera.org:8080/21544 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01f7781f24644a66e9ec52652450116f5cb4297 Gerrit-Change-Number: 21544 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 21 Jun 2024 22:39:24 +0000 Gerrit-HasComments: Yes
