Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21463 )
Change subject: IMPALA-13106: Support larger imported query profile sizes through compression ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21463/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21463/4//COMMIT_MSG@37 PS4, Line 37: Added tests for the compression library methods utilized by > Please mention manual testing. What browsers is this tested on? Automated tests have been written for compression. This has been tested on Chrome and Firefox. http://gerrit.cloudera.org:8080/#/c/21463/4/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/21463/4/www/queries.tmpl@341 PS4, Line 341: uploadProfile(); > Why is being done recursively vs in a loop? What is the behavior if there a Web workers operate in a single thread, the processing is sequential. If we wait for the response within a loop, then there is no point in using a web worker. So, without blocking the main thread, the function "uploadProfile" is being called after processing of each query has finished by the web worker. If an error is encountered, subsequent queries are not uploaded. -- To view, visit http://gerrit.cloudera.org:8080/21463 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4f31beb9cac89051460bf764b6d50c3933bd03 Gerrit-Change-Number: 21463 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 24 Jun 2024 09:17:49 +0000 Gerrit-HasComments: Yes
