Kurt Deschler has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21463 )

Change subject: IMPALA-13106: Support larger imported query profile sizes 
through compression
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21463/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21463/4//COMMIT_MSG@37
PS4, Line 37: Added tests for the compression library methods utilized by
Please mention manual testing. What browsers is this tested on?


http://gerrit.cloudera.org:8080/#/c/21463/4/www/queries.tmpl
File www/queries.tmpl:

http://gerrit.cloudera.org:8080/#/c/21463/4/www/queries.tmpl@341
PS4, Line 341:         uploadProfile();
Why is being done recursively vs in a loop? What is the behavior if there are 
multiple errors?



--
To view, visit http://gerrit.cloudera.org:8080/21463
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c4f31beb9cac89051460bf764b6d50c3933bd03
Gerrit-Change-Number: 21463
Gerrit-PatchSet: 4
Gerrit-Owner: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Comment-Date: Fri, 21 Jun 2024 12:59:36 +0000
Gerrit-HasComments: Yes

Reply via email to