Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21510 )
Change subject: IMPALA-13156: Investigation: Set explicit credential provider for S3 builds ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21510/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py: http://gerrit.cloudera.org:8080/#/c/21510/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py@152 PS1, Line 152: et("RUNNING_IN_EC2") == 'true' ) : > I like using a release tag for a shorter URL. i stayed with the branch name, and added extra wording to direct readers to the decision table http://gerrit.cloudera.org:8080/#/c/21510/1/tests/custom_cluster/test_s3a_access.py File tests/custom_cluster/test_s3a_access.py: http://gerrit.cloudera.org:8080/#/c/21510/1/tests/custom_cluster/test_s3a_access.py@69 PS1, Line 69: > flake8: E501 line too long (92 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/21510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c09f8d042a69c5d3227398c720ea38e1c7e12f Gerrit-Change-Number: 21510 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 12 Jul 2024 23:32:09 +0000 Gerrit-HasComments: Yes
