Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21510 )
Change subject: IMPALA-13156: Investigation: Set explicit credential provider for S3 builds ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21510/3/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py: http://gerrit.cloudera.org:8080/#/c/21510/3/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py@149 PS3, Line 149: https://github.com/apache/impala/blob/master/bin/impala-config.sh#L668-L689 This has now drifted pretty substantially. It is possible to shorten the commithash like so: https://github.com/apache/impala/blob/89698426f6/bin/impala-config.sh#L723-L744 I'm using 10 digits here, but 8 also works. -- To view, visit http://gerrit.cloudera.org:8080/21510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c09f8d042a69c5d3227398c720ea38e1c7e12f Gerrit-Change-Number: 21510 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 18:17:55 +0000 Gerrit-HasComments: Yes
