Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21510 )
Change subject: IMPALA-13156: Investigation: Set explicit credential provider for S3 builds ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21510/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py: http://gerrit.cloudera.org:8080/#/c/21510/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py@152 PS1, Line 152: et("RUNNING_IN_EC2") == 'true' ) : > I like using a release tag for a shorter URL. That works too. http://gerrit.cloudera.org:8080/#/c/21510/3/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py: http://gerrit.cloudera.org:8080/#/c/21510/3/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py@147 PS3, Line 147: # Figure out if we are running in an EC2 VM, with S3 credentials supplied by an IAM Should this block of code reference IMPALA-13156 or is it intended to be a permanent change? -- To view, visit http://gerrit.cloudera.org:8080/21510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8c09f8d042a69c5d3227398c720ea38e1c7e12f Gerrit-Change-Number: 21510 Gerrit-PatchSet: 3 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 17 Jul 2024 23:53:56 +0000 Gerrit-HasComments: Yes
