Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 )
Change subject: IMPALA-6337: Fix infinite loop in Impala shell ...................................................................... Patch Set 13: > Patch Set 12: > > (1 comment) > > > Yeah I think it's a good idea to upgrade sqlparse to the last version that > > supports Python 2.6 especially if we intend to use a vendored sqlparse. IMO > > it's cleaner to do the upgrade in a separate patch and the apply the bug fix > > in another patch. We can either upgrade first and apply the bug fix or apply > > the bug fix first and then upgrade. Either way works for me. Thoughts? > > I think upgrading first makes the most sense to me. > > And thanks for clarifying my other questions. The backported bugfix is now based on the upgraded sqlparse-0.1.19. Please re-review this CR again. -- To view, visit http://gerrit.cloudera.org:8080/9195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b Gerrit-Change-Number: 9195 Gerrit-PatchSet: 13 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 10 May 2018 23:26:34 +0000 Gerrit-HasComments: No
