David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9195 )
Change subject: IMPALA-6337: Fix infinite loop in Impala shell ...................................................................... Patch Set 12: (1 comment) > Yeah I think it's a good idea to upgrade sqlparse to the last version that > supports Python 2.6 especially if we intend to use a vendored sqlparse. IMO > it's cleaner to do the upgrade in a separate patch and the apply the bug fix > in another patch. We can either upgrade first and apply the bug fix or apply > the bug fix first and then upgrade. Either way works for me. Thoughts? I think upgrading first makes the most sense to me. And thanks for clarifying my other questions. http://gerrit.cloudera.org:8080/#/c/9195/9/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9195/9/shell/impala_shell.py@601 PS9, Line 601: except AttributeError: > Checking if the bug can yield to an infinite loop can be tricky to do. Furt Done -- To view, visit http://gerrit.cloudera.org:8080/9195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9142f21a888189d351f00ce09baeba123bc0959b Gerrit-Change-Number: 9195 Gerrit-PatchSet: 12 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 08 May 2018 16:17:11 +0000 Gerrit-HasComments: Yes
