Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21617 )
Change subject: IMPALA-13256: Support more than 2G rows for count star on jdbc table ...................................................................... Patch Set 2: (3 comments) Thanks Wenzhe! I've added some minor nits but otherwise the patch looks good. http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@10 PS2, Line 10: causes Impala to thrown nit: caused Impala to throw an http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@18 PS2, Line 18: Manually created a jdbc table jdbc_table with more than 2G rows, : verified that query 'select count(*) from jdbc_table' returned : correct number of rows. I think it'd be good if we can add some tests or mention steps/tables for which it failed and works now. http://gerrit.cloudera.org:8080/#/c/21617/2/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/21617/2/be/src/exec/data-source-scan-node.cc@146 PS2, Line 146: DCHECK_LE(input_batch_->rows.num_rows, 0x7FFFFFFF); nit: Can we add a comment about this check, something like this: Check to prevent overflow. -- To view, visit http://gerrit.cloudera.org:8080/21617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334 Gerrit-Change-Number: 21617 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2024 03:31:51 +0000 Gerrit-HasComments: Yes
