Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21617 )
Change subject: IMPALA-13256: Support more than 2G rows for COUNT(*) on jdbc table ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Some minor nits. http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@18 PS2, Line 18: Manually created a jdbc table jdbc_table with more than 2G rows, : verified that query 'select count(*) from jdbc_table' returned : correct number of rows. > The table is too big and may hit memory issue when creating such big table Ack http://gerrit.cloudera.org:8080/#/c/21617/3/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/21617/3/be/src/exec/data-source-scan-node.cc@146 PS3, Line 146: 4 byte nit: a 4-byte http://gerrit.cloudera.org:8080/#/c/21617/3/be/src/exec/data-source-scan-node.cc@146 PS3, Line 146: Make sure number nit: Making sure that the http://gerrit.cloudera.org:8080/#/c/21617/3/be/src/exec/data-source-scan-node.cc@147 PS3, Line 147: not to exceed nit: does not exceed -- To view, visit http://gerrit.cloudera.org:8080/21617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334 Gerrit-Change-Number: 21617 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2024 19:08:05 +0000 Gerrit-HasComments: Yes
