Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21617 )
Change subject: IMPALA-13256: Support more than 2G rows for COUNT(*) on jdbc table ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@7 PS2, Line 7: COUNT(*) o > nit: Shouldn't it be COUNT(*) fixed http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@10 PS2, Line 10: caused Impala to throw > nit: caused Impala to throw an fixed http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@11 PS2, Line 11: COUNT(*) q > nit: Shouldn't it be COUNT(*) fixed http://gerrit.cloudera.org:8080/#/c/21617/2//COMMIT_MSG@18 PS2, Line 18: Manually created a jdbc table jdbc_table with more than 2G rows, : verified that query 'select count(*) from jdbc_table' returned : correct number of rows. > I think it'd be good if we can add some tests or mention steps/tables for w The table is too big and may hit memory issue when creating such big table in runtime. It takes additional disk space in Jenkins and developers' machine if add unit-test. I added detail steps in the comments of IMPALA-13256. http://gerrit.cloudera.org:8080/#/c/21617/2/be/src/exec/data-source-scan-node.cc File be/src/exec/data-source-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/21617/2/be/src/exec/data-source-scan-node.cc@146 PS2, Line 146: // The capacity of output RowBatch is defined as 4 > nit: Can we add a comment about this check, something like this: Added a comment. -- To view, visit http://gerrit.cloudera.org:8080/21617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334 Gerrit-Change-Number: 21617 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Sun, 28 Jul 2024 07:03:49 +0000 Gerrit-HasComments: Yes
