Hello Quanlong Huang, Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21733
to look at the new patch set (#2).
Change subject: IMPALA-13341: Fix mismatch exec option values in py.test files
......................................................................
IMPALA-13341: Fix mismatch exec option values in py.test files
IMPALA-13323 added WARNING log if, for independently declared
query option 'key',
vector.get_value('exec_option')['key'] != vector.get_value('key').
This patch eliminate such WARNING logs by fixing exec option declaration
in test_mem_usage_scaling.py and test_update_stress.py, the only test
producing the WARNING log. Here are the summary of the patch:
- Declare 'mem_limit' using add_exec_option_dimension helper function in
TestQueryMemLimitScaling so that 'mem_limit' dimension is not
silently ignored.
- Declare 'batch_size' using create_exec_option_dimension helper
function in TestIcebergV2UpdateStress to override the default
'exec_option' dimension (containing batch_size=0) that initialized by
ImpalaTestSuite.add_test_dimensions().
- Rename 'mem_limit' dimension to 'test_mem_limit' dimension for
subclasses of TestLowMemoryLimits. The final 'mem_limit' option
is still calculated from 'test_mem_limit' dimension.
- Change the LOG.warn() into pytest.fail() to prevent new tests from
repeating the same issue.
- Address few flake8 warnings and errors.
Testing:
- Pass exhaustive tests for test_mem_usage_scaling.py and
test_update_stress.py.
Change-Id: Ic34187782c51c6d6fc0a688c9c5f72bf0cb2d45c
---
M tests/common/impala_test_suite.py
M tests/query_test/test_mem_usage_scaling.py
M tests/stress/test_update_stress.py
3 files changed, 26 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/21733/2
--
To view, visit http://gerrit.cloudera.org:8080/21733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic34187782c51c6d6fc0a688c9c5f72bf0cb2d45c
Gerrit-Change-Number: 21733
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
