Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21733 )
Change subject: IMPALA-13341: Fix mismatch exec option values in py.test files ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21733/2/tests/query_test/test_mem_usage_scaling.py File tests/query_test/test_mem_usage_scaling.py: http://gerrit.cloudera.org:8080/#/c/21733/2/tests/query_test/test_mem_usage_scaling.py@111 PS2, Line 111: # Mem consumption can be +-30MBs, depending on how many scanner threads are > Unrelated, but would it make sense to limit the number of scanner threads v I think so. But fixing num scanner threads will require adjusting TestTpchMemLimitError.MIN_MEM_FOR_TPCH and TestTpchPrimitivesMemLimitError.MIN_MEM so that the outcome of 'expects_error' variable below stays the same. The test has been running well until now, so I rather not changing it. -- To view, visit http://gerrit.cloudera.org:8080/21733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34187782c51c6d6fc0a688c9c5f72bf0cb2d45c Gerrit-Change-Number: 21733 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 18:40:41 +0000 Gerrit-HasComments: Yes
